Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): do not set bodyUsed to undefined #1346

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

tniessen
Copy link
Member

Fixes: #1345

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #1346 (31b3a9c) into main (7c1a52c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1346      +/-   ##
==========================================
+ Coverage   94.12%   94.14%   +0.02%     
==========================================
  Files          45       45              
  Lines        4204     4204              
==========================================
+ Hits         3957     3958       +1     
+ Misses        247      246       -1     
Impacted Files Coverage Δ
lib/fetch/body.js 98.33% <100.00%> (ø)
lib/fetch/request.js 86.07% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1a52c...31b3a9c. Read the comment docs.

@tniessen tniessen added the fetch label Apr 18, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b6a7262 into nodejs:main Apr 18, 2022
tniessen added a commit to tniessen/node that referenced this pull request May 3, 2022
tniessen added a commit to tniessen/node that referenced this pull request May 3, 2022
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request May 5, 2022
Refs: #42701
Refs: nodejs/undici#1346
Refs: #42939

PR-URL: #42960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request May 10, 2022
Refs: #42701
Refs: nodejs/undici#1346
Refs: #42939

PR-URL: #42960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response.bodyUsed is undefined when body is null
4 participants